Crash by effect having specific structure in D3D9
- seri14
- Topic Author
Less
More
5 years 3 months ago #1
by seri14
Crash by effect having specific structure in D3D9 was created by seri14
I want to create a issue because I am not sure changes of my wrote, but it page is not exist.
I report here.
An access violation occurs in rendering the technique of the self made effect at executed with ReShade32.exe -d3d9
I guess when calling DirectX 9 using the effect's storage, passed over 16bytes extra.
Is my guess correct?
My effect: KeepUI_FFXIV.fx (gist)
I tried fix: Commits (github)
I report here.
An access violation occurs in rendering the technique of the self made effect at executed with ReShade32.exe -d3d9
I guess when calling DirectX 9 using the effect's storage, passed over 16bytes extra.
Is my guess correct?
My effect: KeepUI_FFXIV.fx (gist)
I tried fix: Commits (github)
Please Log in or Create an account to join the conversation.
- crosire
Less
More
5 years 3 months ago #2
by crosire
Replied by crosire on topic Crash by effect having specific structure in D3D9
Can't manage to reproduce a crash. Could you upload your full preset + shaders?
Please Log in or Create an account to join the conversation.
- seri14
- Topic Author
Less
More
5 years 3 months ago - 5 years 3 months ago #3
by seri14
Replied by seri14 on topic Crash by effect having specific structure in D3D9
1. Set command arguments of debugging to -d3d9 in VS2017
2. Download the KeepUI_FFXIV.fx from first post to Debug App\
3. Remove files except these
KeepUI_FFXIV.fx
ReShade.fxh
ReShade32.exe, .exp, .ilk, .lib, .log, .pdb
4. Start debug and try enable the FFKeepUI technique (should occurs exception)
2. Download the KeepUI_FFXIV.fx from first post to Debug App\
3. Remove files except these
KeepUI_FFXIV.fx
ReShade.fxh
ReShade32.exe, .exp, .ilk, .lib, .log, .pdb
4. Start debug and try enable the FFKeepUI technique (should occurs exception)
Last edit: 5 years 3 months ago by seri14.
Please Log in or Create an account to join the conversation.
- crosire
Less
More
5 years 3 months ago #4
by crosire
Replied by crosire on topic Crash by effect having specific structure in D3D9
Ah, I had done that, but hadn't restarted, so the cache was still big enough. Can now reproduce this.
Please Log in or Create an account to join the conversation.
- crosire
Less
More
5 years 3 months ago - 5 years 3 months ago #5
by crosire
Replied by crosire on topic Crash by effect having specific structure in D3D9
Fixed:
github.com/crosire/reshade/commit/6b451f...fdbc16ca3ff99e4614eb
The code to round up to the next multiple of 16 was wrong.
The code to round up to the next multiple of 16 was wrong.
Last edit: 5 years 3 months ago by crosire.
The following user(s) said Thank You: seri14
Please Log in or Create an account to join the conversation.