Vulkan Crash on startup
- Niko of Death
-
Topic Author
More
- JBeckman
-
More
4 years 8 months ago - 4 years 8 months ago #2
by JBeckman
Replied by JBeckman on topic Vulkan Crash on startup
Wonder how sensitive the drivers are and what it requires for the VLK runtime but I suppose if Rage 2 works being based on the 1.1.x SDK instead of 1.0.x that shouldn't be a big thing though the drivers could be a issue.
Suppose it also depends on how release ready the current VLK support is I guess and comparing with D3D12 from the prior ReShade version that still sees crashes in a few games so there might be some cases where it's not going to be performing as expected.
Rage 2 as a pure Vulkan game would also only called Vulkan-1.dll and the runtime (1.1.108.0 release, bit higher from the SDK itself I think but not available yet.) and then AMD and NVIDIA have varying support and ways they handle this though for NVIDIA the beta VLK drivers while a older main branch should be fully up to date for the current SDK version.
For AMD the 19.6.x drivers changed the VLK inclusion to be a AMD built runtime so signatures, size and such all differ from the official it might not mean anything but as it's 1.1.106.0 based and these are backwars compatible my own way is to re-install the latest official runtime afterwards to ensure it's unmodified.
(It's something like a loader, core parts are the driver files and how the game uses the SDK it's compiled against. vulkan.lunarg.com/sdk/home#windows )
Previously it just included VulkanRT.exe installing whatever version that was though it could take a while for it to be updated and now it's this thing but at least the runtime is backwards compatible for 1.0 and 1.1 both.
Extensions, hacks and other stuff in the code could also make a difference even if 1.1 and Rage 2 here as the first(?) full game to use this has many things as a standard instead of special implementations or little "hacks" such as what DOOM 2016 or Wolfenstein New Colossus used. (Async compute support instead of going with some AMD GCN functionality and more.)
Going by the DXVK project the AMD Windows VLK drivers are also not that great compared to either their own Linux drivers or the open source ones but what this changes or breaks or lacks support for beyond some extensions I couldn't quite say, NVIDIA I know even less about for their Windows VLK support for the main driver and what it looks like for the beta driver even if it has the newest extensions supported.
(Driver bugs exist in both though and for Intel, low level API's being all finicky I'm guessing and also tricky with supporting and maintaining.)
Emulators with VLK support could be another way to test ReShade, injection through Vulkan-1.dll seems to be in place in the current code base but other features could still be lacking and thus it crashes instead, suppose a more detailed log or debugger would be needed to get the exact nature of the error.
EDIT: There's the injection, creating the swap chain, hooking various pieces of this process and device creation and then after that comes stuff like depth buffer support (Think 4.3.1 makes a improvement here for D3D12) so hooking might be supported for VLK but it might still not be enough to fully initialize and create the display window and process without crashing, setting up the swap chain and steps up until it can boot or well I know the basics but not very well.
Perhaps it's that going by the documentation and not enough support currently?
VK_ERROR_DEVICE_LOST
Will be interesting to read more on this and see how VLK support is coming along.
EDIT: That and going backwards through the ReShade Github commits might also tell what pieces are in place and what's missing.
EDIT: Oh and if it's self-compiled then the runtimes and dependencies will also be a important pat, I think a earlier commit removed the Vulkan SDK as a required criteria but it could still be needed for VLK support if you're building the DLL with intent for using this API for example.
github.com/crosire/reshade/commit/4ea04c...7ac41523c9936c1ad87f
DLLMain.cpp I guess would be the file then?
#pragma region Vulkan Implementation
#define VK_CHECK(exp) assert((exp) == VK_SUCCESS)
#define VK_CALL_CMD(name, device, ...) reinterpret_cast<PFN_##name>(vkGetDeviceProcAddr(device, #name))(__VA_ARGS__)
#define VK_CALL_DEV(name, device, ...) reinterpret_cast<PFN_##name>(vkGetDeviceProcAddr(device, #name))(device, __VA_ARGS__)
#define VK_CALL_INS(name, instance, ...) reinterpret_cast<PFN_##name>(vkGetInstanceProcAddr(instance, #name))(__VA_ARGS__)
Checking what it reports and if it succeeds or fails since it has that pragma here.
Or I could be reading it wrong and ReShade has support in the source itself although I don't think you can just decouple the entire VLK SDK and still have it work so it's a optional part for getting the VLK injection functional same as say D3D12 and the newer Win10 SDK's I'd imagine and being able to opt out of that for still compiling on OS's without this being available.
(Going in circles here but having it as a optional but not a required criteria for certain functionality to be exposed and available as the user compiles the ReShade source code from scratch.)
EDIT: Oh interesting so a third party proxy could actually work. Neat!
Suppose it also depends on how release ready the current VLK support is I guess and comparing with D3D12 from the prior ReShade version that still sees crashes in a few games so there might be some cases where it's not going to be performing as expected.
Rage 2 as a pure Vulkan game would also only called Vulkan-1.dll and the runtime (1.1.108.0 release, bit higher from the SDK itself I think but not available yet.) and then AMD and NVIDIA have varying support and ways they handle this though for NVIDIA the beta VLK drivers while a older main branch should be fully up to date for the current SDK version.
For AMD the 19.6.x drivers changed the VLK inclusion to be a AMD built runtime so signatures, size and such all differ from the official it might not mean anything but as it's 1.1.106.0 based and these are backwars compatible my own way is to re-install the latest official runtime afterwards to ensure it's unmodified.
(It's something like a loader, core parts are the driver files and how the game uses the SDK it's compiled against. vulkan.lunarg.com/sdk/home#windows )
Previously it just included VulkanRT.exe installing whatever version that was though it could take a while for it to be updated and now it's this thing but at least the runtime is backwards compatible for 1.0 and 1.1 both.
Extensions, hacks and other stuff in the code could also make a difference even if 1.1 and Rage 2 here as the first(?) full game to use this has many things as a standard instead of special implementations or little "hacks" such as what DOOM 2016 or Wolfenstein New Colossus used. (Async compute support instead of going with some AMD GCN functionality and more.)
Going by the DXVK project the AMD Windows VLK drivers are also not that great compared to either their own Linux drivers or the open source ones but what this changes or breaks or lacks support for beyond some extensions I couldn't quite say, NVIDIA I know even less about for their Windows VLK support for the main driver and what it looks like for the beta driver even if it has the newest extensions supported.
(Driver bugs exist in both though and for Intel, low level API's being all finicky I'm guessing and also tricky with supporting and maintaining.)
Emulators with VLK support could be another way to test ReShade, injection through Vulkan-1.dll seems to be in place in the current code base but other features could still be lacking and thus it crashes instead, suppose a more detailed log or debugger would be needed to get the exact nature of the error.
EDIT: There's the injection, creating the swap chain, hooking various pieces of this process and device creation and then after that comes stuff like depth buffer support (Think 4.3.1 makes a improvement here for D3D12) so hooking might be supported for VLK but it might still not be enough to fully initialize and create the display window and process without crashing, setting up the swap chain and steps up until it can boot or well I know the basics but not very well.
Perhaps it's that going by the documentation and not enough support currently?
VK_ERROR_DEVICE_LOST
Will be interesting to read more on this and see how VLK support is coming along.
EDIT: That and going backwards through the ReShade Github commits might also tell what pieces are in place and what's missing.
EDIT: Oh and if it's self-compiled then the runtimes and dependencies will also be a important pat, I think a earlier commit removed the Vulkan SDK as a required criteria but it could still be needed for VLK support if you're building the DLL with intent for using this API for example.
github.com/crosire/reshade/commit/4ea04c...7ac41523c9936c1ad87f
DLLMain.cpp I guess would be the file then?
#pragma region Vulkan Implementation
#define VK_CHECK(exp) assert((exp) == VK_SUCCESS)
#define VK_CALL_CMD(name, device, ...) reinterpret_cast<PFN_##name>(vkGetDeviceProcAddr(device, #name))(__VA_ARGS__)
#define VK_CALL_DEV(name, device, ...) reinterpret_cast<PFN_##name>(vkGetDeviceProcAddr(device, #name))(device, __VA_ARGS__)
#define VK_CALL_INS(name, instance, ...) reinterpret_cast<PFN_##name>(vkGetInstanceProcAddr(instance, #name))(__VA_ARGS__)
Checking what it reports and if it succeeds or fails since it has that pragma here.
Or I could be reading it wrong and ReShade has support in the source itself although I don't think you can just decouple the entire VLK SDK and still have it work so it's a optional part for getting the VLK injection functional same as say D3D12 and the newer Win10 SDK's I'd imagine and being able to opt out of that for still compiling on OS's without this being available.
(Going in circles here but having it as a optional but not a required criteria for certain functionality to be exposed and available as the user compiles the ReShade source code from scratch.)
EDIT: Oh interesting so a third party proxy could actually work. Neat!
Last edit: 4 years 8 months ago by JBeckman.
Please Log in or Create an account to join the conversation.
- crosire
-
More
- Niko of Death
-
More
- Zireael
-
More
- JBeckman
-
More
- Wicked Sick
-
More