Bug report: BUFFER_COLOR_SPACE doesn't change when game's output changes

More
5 months 2 weeks ago #1 by rj200 Bug report: BUFFER_COLOR_SPACE doesn't change when game's output changes was created by rj200
Steps to reproduce: 
  1. Play a game with optional HDR support that can be toggled in the menu (e.g. Horizon Zero Dawn).
  2. Run shader that changes behavior based on BUFFER_COLOR_SPACE
  3. Turn HDR on/off
  4. Check if shader adapted.
This could cause problems when users are first setting up games, or switching screens. I imagine it might also cause issues if a game starts with an SDR video/menu then goes HDR in-game.

Suggested fix:
  1. Detect changes and recompile shaders when BUFFER_COLOR_SPACE changes. Include BUFFER_COLOR_SPACE in the hash used when caching shaders.

Note: If you change the game resolution then it can pick up the change, but due to shader caching, if you switch back to a previous resolution it might load shader with wrong cached BUFFER_COLOR_SPACE compiled in.

Please Log in or Create an account to join the conversation.

More
5 months 2 weeks ago #2 by rj200 Replied by rj200 on topic Bug report: BUFFER_COLOR_SPACE doesn't change when game's output changes
The following user(s) said Thank You: crosire

Please Log in or Create an account to join the conversation.

We use cookies

We use cookies on our website. Some of them are essential for the operation of the site, while others help us to improve this site and the user experience (tracking cookies). You can decide for yourself whether you want to allow cookies or not. Please note that if you reject them, you may not be able to use all the functionalities of the site.