Welcome, Guest.
Username: Password: Remember me

TOPIC: Crash by effect having specific structure in D3D9

Crash by effect having specific structure in D3D9 8 months 4 weeks ago #1

I want to create a issue because I am not sure changes of my wrote, but it page is not exist.
I report here.

An access violation occurs in rendering the technique of the self made effect at executed with ReShade32.exe -d3d9

I guess when calling DirectX 9 using the effect's storage, passed over 16bytes extra.
Is my guess correct?

My effect: KeepUI_FFXIV.fx (gist)
I tried fix: Commits (github)
The administrator has disabled public write access.

Crash by effect having specific structure in D3D9 8 months 4 weeks ago #2

Can't manage to reproduce a crash. Could you upload your full preset + shaders?
Cheers, crosire =)
The administrator has disabled public write access.

Crash by effect having specific structure in D3D9 8 months 4 weeks ago #3

1. Set command arguments of debugging to -d3d9 in VS2017
2. Download the KeepUI_FFXIV.fx from first post to Debug App\
3. Remove files except these
KeepUI_FFXIV.fx
ReShade.fxh
ReShade32.exe, .exp, .ilk, .lib, .log, .pdb

4. Start debug and try enable the FFKeepUI technique (should occurs exception)
Last Edit: 8 months 4 weeks ago by seri14.
The administrator has disabled public write access.

Crash by effect having specific structure in D3D9 8 months 4 weeks ago #4

Ah, I had done that, but hadn't restarted, so the cache was still big enough. Can now reproduce this.
Cheers, crosire =)
The administrator has disabled public write access.

Crash by effect having specific structure in D3D9 8 months 4 weeks ago #5

Fixed: github.com/crosire/reshade/commit/6b451f...fdbc16ca3ff99e4614eb

The code to round up to the next multiple of 16 was wrong.
Cheers, crosire =)
Last Edit: 8 months 4 weeks ago by crosire.
The administrator has disabled public write access.
The following user(s) said Thank You: seri14