Welcome, Guest.
Username: Password: Remember me

TOPIC: Assistant displaying wrong SMAA setting ranges?

Assistant displaying wrong SMAA setting ranges? 1 year 1 month ago #1

Hi, sorry if this has been brought up before, but this is just a minor issue I noticed with the ReShade Assistant.

The ReShade Assistant shows incorrect maximum values for SMAA_MAX_SEARCH_STEPS and SMAA_MAX_SEARCH_STEPS_DIAG. ReShade Assistant says the maximum values for them, respectively, are 98 and 16. However, in SMAA.h, the following lines indicate that the maximum values are in fact 112 and 20:
/**
 * SMAA_MAX_SEARCH_STEPS specifies the maximum steps performed in the
 * horizontal/vertical pattern searches, at each side of the pixel.
 *
 * In number of pixels, it's actually the double. So the maximum line length
 * perfectly handled by, for example 16, is 64 (by perfectly, we meant that
 * longer lines won't look as good, but still antialiased).
 *
 * Range: [0, 112]
 */

/**
 * SMAA_MAX_SEARCH_STEPS_DIAG specifies the maximum steps performed in the
 * diagonal pattern searches, at each side of the pixel. In this case we jump
 * one pixel at time, instead of two.
 *
 * Range: [0, 20]
 *
 * On high-end machines it is cheap (between a 0.8x and 0.9x slower for 16 
 * steps), but it can have a significant impact on older machines.
 *
 * Define SMAA_DISABLE_DIAG_DETECTION to disable diagonal processing.
 */

I know this is relatively minor, but I was unsure if this was intentional, or if the ReShade Assistant really does have incorrect maximum values for those two settings. Thanks!
The administrator has disabled public write access.

Assistant displaying wrong SMAA setting ranges? 1 year 1 month ago #2

  • Ganossa
  • Ganossa's Avatar
  • Offline
  • 최정장군
  • Posts: 790
  • Thank you received: 838
The max/min values are automatically generated from the configuration files (if existent) not from the shader file descriptions. There must be a mismatch between shader files description and shader value description in the related configuration file.
The administrator has disabled public write access.

Assistant displaying wrong SMAA setting ranges? 1 year 1 month ago #3

  • crosire
  • crosire's Avatar
  • Offline
  • Posts: 2644
  • Thank you received: 1517
Nah. Somebody just entered the wrong min/max values in the config file. They should be the ones from SMAA.h.
Cheers, crosire =)
The administrator has disabled public write access.