1. Forum
  3. Shaders & Effects
  5. Discussion
  7. Shaders Problems

Shaders Problems

  • Posts: 58
3 years 5 months ago - 3 years 5 months ago #1 by Exilium
I'm waiting for a fix for this since the Reshade Framework. It costs nothing to take a little time to review these effects.

Ambient Light
Horizontal lines in any settings:

File Attachment:


File Attachment:


Emboss
Depth Check not work. Depth Check, if enabled, shader compares emboss samples depth to avoid artifacts at object borders, But as you can see, we have no change at all:

File Attachment:


File Attachment:

Please Log in or Create an account to join the conversation.

  • Posts: 1221
3 years 5 months ago #2 by Marty McFly
First one looks more like dithering to me than AL.
Second one, well, you're using totally crazy settings there, not sure if depth check works properly then.

Please Log in or Create an account to join the conversation.

  • Posts: 58
3 years 5 months ago - 3 years 5 months ago #3 by Exilium
Marty McFly wrote:
First one looks more like dithering to me than AL.

No, I removed all the textures just because I thought it was that, but it continues like this.



Marty McFly wrote:
Second one, well, you're using totally crazy settings there, not sure if depth check works properly then.

Well, I put these extreme settings just to show as an example, but in the normal settings I use, you can clearly see that the depth check does not work. But I think I know why. The Emboss was not ported by the creator, but by an amateur who said "just compared some shaders of Reshade 3.x.x and Reshade 2.x.x, and worked!".
Maybe the bearing has not been done well. I did not find the Emboss anywhere else. In fact, it has a lot of problems with various effects, I can list them here for a fix. I already navigated in all the effects and I already tested all the possible configurations of each one, I already discovered a lot. But, I see that some of the creators do not care about it, very sad.

Please Log in or Create an account to join the conversation.

  • Posts: 1221
3 years 5 months ago #4 by Marty McFly
Hmm, dithering is not texture based, so I don't know what you mean by that.
About emboss, I think it's not a good effect anyways, only wrote it to satisfy a request. And it's not in the github repo?

Please Log in or Create an account to join the conversation.

  • Posts: 58
3 years 5 months ago - 3 years 5 months ago #5 by Exilium
Marty McFly wrote:
Hmm, dithering is not texture based, so I don't know what you mean by that.

Oh sorry! I was thinking that you were talking about the "Lens Dirt" option of Ambient Light.



Marty McFly wrote:
About emboss, I think it's not a good effect anyways, only wrote it to satisfy a request. And it's not in the github repo?

No, unfortunately not. I actually do not really like this effect either, but it's the only one that comes close to anything like Normal Maps. Me and the best modders in the world of NFS are practically redoing the game "Need For Speed Underground 2", but until now it was impossible to add Normal Maps, the engine that the game was developed does not allow us. The only solution so far has been the Emboss, and as you can see, full of problems. We will not be able to add any kind of textures, Normal, Displacement, Specular... We've tried in all ways.

Plus: I saw your VXR, looks nice, better than RBM!

Please Log in or Create an account to join the conversation.

  • Posts: 3
3 years 4 months ago #6 by SoZ
I am unsure whether or not you were able to resolve your issue, but I thought I'd share a link to a post I have just made regarding the dithering code within AmbientLight.fx in case it is useful to you:
AmbientLight.fx (with dither toggle)

Please Log in or Create an account to join the conversation.

  • Posts: 58
3 years 3 months ago #7 by Exilium
Nice one! Thank you!

Please Log in or Create an account to join the conversation.

  • Posts: 144
3 years 3 months ago #8 by Insomnia

The Emboss was not ported by the creator, but by an amateur who said "just compared some shaders of Reshade 3.x.x and Reshade 2.x.x, and worked!".

That someone would be me lol.

Maybe the bearing has not been done well. I did not find the Emboss anywhere else.

This is why I decided to half ass port it tbh. I wanted it for ReShade 3.x and it worked fine in my space games. Last I remember I removed the depth check because I didn't know how to approach it.
And I would never upload any of my amateur ports to GitHub just because of this. Sorry but I can't do much better. :(

Please Log in or Create an account to join the conversation.

  • Posts: 58
3 years 3 months ago #9 by Exilium
Insomnia wrote:
That someone would be me lol.

Hey. :) Thanks for porting.Too bad you have removed this option. This effect is the only one that approaches something like a normal map. I tried to merge 3 shaders a while back, Emboss, RBM and High Pass Sharpening. I got something up that pretty interesting and quite close to a normal map. The problems were the Emboss, which creates black borders on the objects (due to the depth check that does not work), and the RBM that is not applied in all textures.

Please Log in or Create an account to join the conversation.

  • Posts: 144
3 years 3 months ago #10 by Insomnia
If you are more accustomed with shader programming, please add a working depth check in the thread with all the ported ReShade 2.x effects. I barely know what the hell I'm doing...
The following user(s) said Thank You: Exilium

Please Log in or Create an account to join the conversation.