Marty McFly's Ambient Obscurance (MXAO) with IL

GP-Unity wrote: I'm using the latest version of Reshade with MXAO 3.1.0 (the one with blending modes) and in the few games i've tested it doesn't seem to work as intended. I have to increase the value for sample radius and ambient occlusion to really high amounts (around 50) to try and get the expected results. This does have the side effect of overly bold AO (if that makes sense). I do make sure the preprocessor definitions are accurate for the games. I'm assuming this problem might be tied to possible depth access changes made in Reshade's latest version?

GP-Unity wrote: I'm using the latest version of Reshade with MXAO 3.1.0 (the one with blending modes) and in the few games i've tested it doesn't seem to work as intended. I have to increase the value for sample radius and ambient occlusion to really high amounts (around 50) to try and get the expected results. This does have the side effect of overly bold AO (if that makes sense). I do make sure the preprocessor definitions are accurate for the games. I'm assuming this problem might be tied to possible depth access changes made in Reshade's latest version?

Chaosrik wrote: Great shader. Just trying to get it to work with American Truck Simulator. Have managed to get it working but only with in-game graphic scaling of 100% - not with 400%. Anyway to change it so it can cope with scaling as its only a quarter size in the corner of screen ?

Marty McFly wrote: I wanted to upload it to github but then I made some amazing progress: a rewritten sample placement allows me to drop the sample counts of all quality presets, so "very low" for example looks same with 4 samples (new code) and 8 samples (old code) so I went ahead and lowered all qualities respectively this should boost performance a lot with same visuals. What I need to refine is the blur code, I made a rather vast change to it but it's hard to tweak right now and I'd prefer if it could work without user interaction just like the old one.
[strike]I'll continue working on this, got another2 ideas which I'd like to try out after that, then I'll release and update the github one.[/strike]

Tested both, turned out beautifully. MXAO just got faster!

Chaosrik wrote: Ok, thanks. I ended up using DSR, works fine. However I've come across a problem when using MXAO with SMAA (using the depth buffer). I had to flip the depth buffer to get MXAO to work with the game but the buffer is now upside down for SMAA predication (checked with SMAA debug). Anyway to fix this ? SMAA works well without predication but I thought I could improve it.

Martigen wrote:

Chaosrik wrote: Ok, thanks. I ended up using DSR, works fine. However I've come across a problem when using MXAO with SMAA (using the depth buffer). I had to flip the depth buffer to get MXAO to work with the game but the buffer is now upside down for SMAA predication (checked with SMAA debug). Anyway to fix this ? SMAA works well without predication but I thought I could improve it.

Wait... is SMAA not honouring the depth buffer properly?

Looking quickly at the shader there's a couple of references to Reshade::DepthBuffer, but all the other depth-based shaders appear to use Reshade::GetLinearizedDepth(texcoord). Could that be the problem?

@Crosire might be able to advise. If it is incorrect good bug catch

NoMansReshade wrote: Not that it's necessarily anything impressive, I'm just curious of your take on a method of AO dubbed "NNAO" (Neural Network Ambient Occlusion). This method is detailed on this paper: theorangeduck.com/media/uploads/other_stuff/nnao.pdf

As well as "GTAO" (Ground Truth Ambient Occlusion). Detailed here: iryoku.com/downloads/Practical-Realtime-...direct-Occlusion.pdf

Chaosrik wrote:

Martigen wrote:

Chaosrik wrote: Ok, thanks. I ended up using DSR, works fine. However I've come across a problem when using MXAO with SMAA (using the depth buffer). I had to flip the depth buffer to get MXAO to work with the game but the buffer is now upside down for SMAA predication (checked with SMAA debug). Anyway to fix this ? SMAA works well without predication but I thought I could improve it.

Wait... is SMAA not honouring the depth buffer properly?

Looking quickly at the shader there's a couple of references to Reshade::DepthBuffer, but all the other depth-based shaders appear to use Reshade::GetLinearizedDepth(texcoord). Could that be the problem?

@Crosire might be able to advise. If it is incorrect good bug catch

Yeah I saw that too. Not sure why SMAA should be different. I'm sure they'll be a reason. Maybe a way to change smaa.fx ?

Chaosrik wrote:

Martigen wrote:

Chaosrik wrote: Ok, thanks. I ended up using DSR, works fine. However I've come across a problem when using MXAO with SMAA (using the depth buffer). I had to flip the depth buffer to get MXAO to work with the game but the buffer is now upside down for SMAA predication (checked with SMAA debug). Anyway to fix this ? SMAA works well without predication but I thought I could improve it.

Wait... is SMAA not honouring the depth buffer properly?

Looking quickly at the shader there's a couple of references to Reshade::DepthBuffer, but all the other depth-based shaders appear to use Reshade::GetLinearizedDepth(texcoord). Could that be the problem?

@Crosire might be able to advise. If it is incorrect good bug catch

Yeah I saw that too. Not sure why SMAA should be different. I'm sure they'll be a reason. Maybe a way to change smaa.fx ?

#if RESHADE_DEPTH_INPUT_IS_UPSIDE_DOWN
float3 neighbours = SMAAGatherNeighbours(float2 (texcoord.x, 1.0-texcoord.y), offset, SMAATexturePass2D(depthTex));
#else

#endif
#if RESHADE_DEPTH_INPUT_IS_REVERSED
neighbours = float3 (1.0, 1.0, 1.0) - neighbours;
#endif

+ Corrected ReShade's SMAA shader so that edge-detection when using depth respects the "upside down" pre-processor definition.

The fixed SMAA shader that can do depth-edge detection in Unity engine games is included in the 0.8.50 release notes. I cannot package SweetFX, etc. shaders with my mods. But I can link you to corrected shaders as need be.

/**
 * Depth Edge Detection
 */
float2 SMAADepthEdgeDetectionPS(float2 texcoord,
                                float4 offset[3],
                                SMAATexture2D(depthTex)) {
#if RESHADE_DEPTH_INPUT_IS_UPSIDE_DOWN
    float3 neighbours = SMAAGatherNeighbours(float2 (texcoord.x, 1.0-texcoord.y), offset, SMAATexturePass2D(depthTex));
#else
    float3 neighbours = SMAAGatherNeighbours(texcoord, offset, SMAATexturePass2D(depthTex));
#endif
#if RESHADE_DEPTH_INPUT_IS_REVERSED
    neighbours = float3 (1.0, 1.0, 1.0) - neighbours;
#endif
    float2 delta = abs(neighbours.xx - float2(neighbours.y, neighbours.z));
    float2 edges = step(SMAA_DEPTH_THRESHOLD, delta);

    if (dot(edges, float2(1.0, 1.0)) == 0.0)
        discard;

    return edges;
}