Welcome, Guest.
Username: Password: Remember me

TOPIC: Some shaders fail to compile in GitHub version

Some shaders fail to compile in GitHub version 2 weeks 2 days ago #1

In order to get the latest bugfixes I built ReShade from the GitHub repo but in some d3d11 games some shaders fail to compile. To be specific: shaders fail that declare a texture and don't use a literal expression for the width and height values.
Example (Dark Souls III):
F:\GitHub\reshade-shaders-crosire\Shaders\CinematicDOF.fx(281, 27): error X3011: value must be a literal expression
Lines 280 & 281 from CinematicDOF:
texture texCDCoCTmp2 { Width = BUFFER_WIDTH; Height = BUFFER_HEIGHT; Format = R16F; };.
texture texCDCoCTileTmp { Width = BUFFER_WIDTH/((TILE_SIZE*2)+1); Height = BUFFER_HEIGHT/((TILE_SIZE*2)+1); Format = R16F; };

Any ideas whether I can do anything on my end to fix this?
The latest release works fine btw, so it's currently not a big issue.
Last Edit: 2 weeks 2 days ago by Daodan.
The administrator has disabled public write access.

Some shaders fail to compile in GitHub version 2 weeks 2 days ago #2

It compiles fine on both branches for me ("master" and "codegen" which contains a new experimental compiler partly written from scratch, with lots of improvements) :huh:. Try to sync to top-of-tree again and do a clean rebuild. Because that shader uses a literal expression (yes, there is math involved, but on constants, so it can be evaluated at compile-time), otherwise the error would be correct.
Cheers, crosire =)
The administrator has disabled public write access.

Some shaders fail to compile in GitHub version 2 weeks 2 days ago #3

I cloned the repo again yesterday and built ReShade and now the issue arises only in DS3. Before that any d3d11 game was affected.

Just to make sure I didn't screw anything up, here's what I did:
  1. Cloning rehshade:
    $ git clone --recurse-submodules https://github.com/crosire/reshade.git
  2. Build: Release 32-bit and 64-bit
  3. Build: Release Setup 64-bit
The administrator has disabled public write access.