Welcome, Guest.
Username: Password: Remember me

TOPIC: ReShade Framework Released (5102.03.29.4151)

ReShade Framework Released (5102.03.29.4151) 4 years 4 months ago #21

Thanks LuciferHawk!! I'm soooooo happy to have lumasharpen back in my tool kit =D

I noticed that HBAO always throws a warning no matter the settings. ( It works and is the only AO that throws the warning)
Also the RFX_Transition seems throws an error ( I cant remember if its a warning or an error right now)

I think the other stuff I noticed has been brought up already.

Again great work!! :cheer:
The topic has been locked.

ReShade Framework Released (5102.03.29.4151) 4 years 4 months ago #22

I updated the op with a fixed version. The binaries will stay the same so there is no need in changing the version number (it is only a quick fix after all).
Please check if everything got fixed but I hope it is :)

Additional color correction shader from ME will follow in a following update as explained earlier. With ReinhardLinear and FilmicPass the -in my opinion- most important ones have been ported already to SweetFX.
The topic has been locked.
The following user(s) said Thank You: Wicked Sick, BrandonHortman

ReShade Framework Released (5102.03.29.4151) 4 years 4 months ago #23

HDR mode is fixed.
Toggle key is still unavailable/inoperable
HBAO throws X3556 errors ( I'll post a screen shot in a second )
The topic has been locked.

ReShade Framework Released (5102.03.29.4151) 4 years 4 months ago #24

HBAO warning
The topic has been locked.

ReShade Framework Released (5102.03.29.4151) 4 years 4 months ago #25

That warning (not error) is okay, it will not mess with anything.

EDIT:: Okay I found it.
Change " i%2 " to " i%2f "

Replacing the fixed file right now.


The key toggle should work (I just checked). Did you try the scroll lock key as defined as default?
Last Edit: 4 years 4 months ago by Ganossa.
The topic has been locked.
The following user(s) said Thank You: BrandonHortman

ReShade Framework Released (5102.03.29.4151) 4 years 4 months ago #26

Yeah, Scroll lock, VK_Scroll, or 0x91. It worked for me with MFX, but still no.

I already had hours of work in my CFG files so I replaced all files except for the Gemfx, Mfx, and SFX cfg ( just those three files)

*EDIT*
Adding the F to the end of i%2 ( i%2f) in the SSAO.h fixed the HBAO warnings :cheer:
Last Edit: 4 years 4 months ago by BrandonHortman.
The topic has been locked.

ReShade Framework Released (5102.03.29.4151) 4 years 4 months ago #27

BrandonHortman wrote:
Yeah, Scroll lock, VK_Scroll, or 0x91. It worked for me with MFX, but still no.

Can you check the toggle for another game or with another key? For me it definitly works :huh:
Last Edit: 4 years 4 months ago by Ganossa.
The topic has been locked.

ReShade Framework Released (5102.03.29.4151) 4 years 4 months ago #28

Sure, I have today off and its rainy so its ReShade day =D

I'll try it on Far Cry 4, I was currently using it on Dragon Age Inquisition.
The topic has been locked.

ReShade Framework Released (5102.03.29.4151) 4 years 4 months ago #29

BrandonHortman wrote:
Sure, I have today off and its rainy so its ReShade day =D

I'll try it on Far Cry 4, I was currently using it on Dragon Age Inquisition.

Maybe also try it with a non 64bit game, in case the issue is bound to those binaries. You might also try "VK_SCROLL" instead of "VK_Scroll" in case it is case sensitive.
The topic has been locked.
The following user(s) said Thank You: BrandonHortman

ReShade Framework Released (5102.03.29.4151) 4 years 4 months ago #30

Ok, I tried case sensitive alternatives.
I tried opening the Keycodes.h and selected random keycodes from the list ( spacebar, tab, ect ect)
I opened some of the shaders and searched for Toggle and confirmed that I replaced them ( confirmation from the RFX_ToggleKey string in the file)

No dice.

I dont think I have any 32 bit games. Unless The Witcher 2 is 32 bit. I'll check that now.
The topic has been locked.

ReShade Framework Released (5102.03.29.4151) 4 years 4 months ago #31

Fresh install on Witcher 2 with 32 bit DLLs resulted in no toggle key support also.
I also tried using VK_TAB instead of VK_SCROLL with no results.
The topic has been locked.

ReShade Framework Released (5102.03.29.4151) 4 years 4 months ago #32

Toggle key not working here too. Tried VK_RCONTROL and VK_RMENU and still nothing.
The topic has been locked.

ReShade Framework Released (5102.03.29.4151) 4 years 4 months ago #33

Fresh install on Far Cry 4 also no toggle key support.
I can't figure out why either, I have exhausted my limited cognitive resources on it :cheer:

Seems like it should work fine as far as I can tell.

*edit*
Also tested OpenGL32 on zDoom, no toggle.
Last Edit: 4 years 4 months ago by BrandonHortman.
The topic has been locked.

ReShade Framework Released (5102.03.29.4151) 4 years 4 months ago #34

The framework has no key toggle currently, unless you add the code for it. So that's expected.
Cheers, crosire =)
The topic has been locked.

ReShade Framework Released (5102.03.29.4151) 4 years 4 months ago #35

Lucifer updated the file earlier.
Fixed the HDR erros, HBAO warnings, and included the code for toggle keys.
Its working for him, but not for us so far.

The file is on the first page.
The topic has been locked.

ReShade Framework Released (5102.03.29.4151) 4 years 4 months ago #36

LuciferHawk wrote:

1. Yes, it will be in the next fix (you can define the key in the Common_settings.cfg)
2. Splitscreen (in the Common_settings.cfg) without comparison or slider will use the mask. You can use it for the HUD.
3. According to Marty, the algorithm did not change with the last update. However, the dirt texture differs greatly, so you might want to try replacing the GFX_dirt.png in ReShade/GemFX/Textures with the mcdirt.png from ME (if you like it better).

Thanks :)
Now about 2. question, I can't seem to get it working, here are the settings in my Common_settings.cfg
And about 3. question, yeah I know about the LensDirt texture :D I used the same ones in the preview pictures, but when I opened MasterEffect 1.1.190 again, I saw there were some new values which were not present in your GemFX_settings.cfg, here are those new values. Your LensDirt seems to only have the fLensdirtIntensity while the MasterEffect has these 3 more, could this maybe be the problem?

EDIT: About masking, It seems I forgot that I disabled SplitScreen in ReShade.fx... My bad, sorry :)
Last Edit: 4 years 4 months ago by fuze.
The topic has been locked.

ReShade Framework Released (5102.03.29.4151) 4 years 4 months ago #37

BrandonHortman wrote:
Lucifer updated the file earlier.
Fixed the HDR erros, HBAO warnings, and included the code for toggle keys.
Its working for him, but not for us so far.

The file is on the first page.
Whoops, sorry for the confusion, don't mind me then. =)

You could try to do a folderwide search and replace of "< enabled = true; >" with "< enabled = true; toggle = 0x20; >" for the spacebar as toggle In the ReShade directory inside your game folder.
Cheers, crosire =)
The topic has been locked.
The following user(s) said Thank You: BrandonHortman

ReShade Framework Released (5102.03.29.4151) 4 years 4 months ago #38

Seems like it should work. He has it setup like this ( this is from the DOF.h file)

technique DOF_Tech <bool enabled = RFX_Start_Enabled; int toggle = RFX_ToggleKey; >

Then in Common_settings.cfg he has:

#define RFX_ToggleKey VK_SCROLL //Set the key that should toggle the effects On/Off



The common_settings.cfg is working (split screen works fine from there) , and if I change the toggle key to something not defined in the Keycodes.h, like VK_scroll (a case sensitive fail) then I get an error from it.

It doesn't toggle in any game I own though.

Even tried several different keycodes copied from the keycodes.h. ( Spacebar, tab, scroll lock)

I suppose I could go through all the shaders and change the:

technique DOF_Tech <bool enabled = RFX_Start_Enabled; int toggle = RFX_ToggleKey; >

to

technique DOF_Tech <bool enabled = RFX_Start_Enabled; int toggle = 0x91; >

like you recommended

*Edit*
This also did not work

technique DOF_Tech <bool enabled = RFX_Start_Enabled; int toggle = 0x91; >
technique DOF_Tech <bool enabled = 1; int toggle = 0x91; >
technique DOF_Tech <bool enabled = 1; int toggle = RFX_ToggleKey; >

As well as:
#define RFX_ToggleKey 0x91

I hope this info is helpful to someone :cheer:
Last Edit: 4 years 4 months ago by BrandonHortman.
The topic has been locked.

ReShade Framework Released (5102.03.29.4151) 4 years 4 months ago #39

  • Wicked Sick
  • Wicked Sick's Avatar
  • Offline
  • Die young or suffer (Forgive my poor English)
Lucifer, I noticed something strange. Since I started to use the framework version, I can't use the shift key with the Steam overlay to make upper cases. But I can use the key normally in game. The issue is just in the overlay when writing.

Well, I just wanted to point this out, perhaps is only with me.

Thank you for this, I really like this version.
Finding relief somewhere between a tree's branch and its shade.
The topic has been locked.

ReShade Framework Released (5102.03.29.4151) 4 years 4 months ago #40

BrandonHortman wrote:
This also did not work

technique DOF_Tech <bool enabled = RFX_Start_Enabled; int toggle = 0x91; >
technique DOF_Tech <bool enabled = 1; int toggle = 0x91; >
technique DOF_Tech <bool enabled = 1; int toggle = RFX_ToggleKey; >

As well as:
#define RFX_ToggleKey 0x91

I hope this info is helpful to someone :cheer:

Did you restart the game after changing this? I think i had trouble with a typo and after i fixed it and restarted the game, it started working. I dont remember exactly what i typed wrong the first time though, sorry...
The topic has been locked.