4.1
- Fu-Bama
-
- Offline
Less More
3 years 4 months ago - 3 years 4 months ago #61 by Fu-Bama
Replied by Fu-Bama on topic 4.1.1
Bug report:
• Found that Dark style has alpha slider range above 1.0, so setting it to 1.0 gives semi-transparent UI
• In Blender 2.79 typing anything in ReShade UI gives double input, like 'error' results in 'eerrrroorr'
• Found that Dark style has alpha slider range above 1.0, so setting it to 1.0 gives semi-transparent UI
• In Blender 2.79 typing anything in ReShade UI gives double input, like 'error' results in 'eerrrroorr'
Last edit: 3 years 4 months ago by Fu-Bama.
The topic has been locked.
- Tojkar
-
- Offline
Less More
- Posts: 194
3 years 4 months ago #62 by Tojkar
BTW, The EAC implementation in WD2 was excemplary IMHO. It's easy to disable but multiplayer component is still fair because disabling EAC also disables multiplayer.
Replied by Tojkar on topic 4.1
curiously New Dawn dropped EAC entirely.Did they really listen the consumer side about how stupid decision it is to put EAC in singleplayer game? I must say, I find that unlikely. More likely they just forgot to implement that.
What's wrong with WD2? I've seen a few minor bugs but nothing so major that could actually even annoy me.rendering it unplayable which happened with Watch_Dogs 2 last year for a example of that.
BTW, The EAC implementation in WD2 was excemplary IMHO. It's easy to disable but multiplayer component is still fair because disabling EAC also disables multiplayer.
The topic has been locked.
- crosire
-
Topic Author
- Offline
Less More
- Posts: 4030
3 years 4 months ago #63 by crosire
Replied by crosire on topic 4.1.1
Found that Dark style has alpha slider range above 1.0, so setting it to 1.0 gives semi-transparent UIThis is not a bug. The dark style has a background alpha of 240, which is why it is transparent. The "Global Alpha" value is multiplied on top of whatever the style set. If you want the dark style, but with an opaque background, select the dark style, then switch to the "Custom Advanced" style and change the alpha field of "WindowBg" to 255.
The topic has been locked.
- RandomX89
-
- Offline
Less More
- Posts: 1
- seri14
-
- Offline
Less More
- Posts: 154
- Fu-Bama
-
- Offline
3 years 4 months ago - 3 years 4 months ago #66 by Fu-Bama
Replied by Fu-Bama on topic 4.1.1
Some issues spotted:
• It seems that version 4 loads all shaders despite performance mode (according to splash-screen at the beginning in DXGI x64)
• I don't know if above is the reason, but performance in 4.1.1 is slightly worse than 3.4.1
I really like features in 4.1.1 and loading time, but it would be nice if it had performance advantage over 3.4.1.
Quick question:
Does it take up texture memory when it loads all the shaders? I noticed that some texture-heavy moments in games have bad time in 4.1.1 over 3.4.1 in performance mode.
Some feedback:
• Regarding user experience, colors settings in theme section feels overwhelming, like there are too many options.
• Changing size of the UI by Ctrl+ScrollWheel makes everything blurry, maybe transition between background and text should be half-pixel?
• Regarding text editor, using Shift+Arrow key works nice at selecting text, but Shift+Mouse drag does not, it would be a nice addition.
• It seems that version 4 loads all shaders despite performance mode (according to splash-screen at the beginning in DXGI x64)
• I don't know if above is the reason, but performance in 4.1.1 is slightly worse than 3.4.1

I really like features in 4.1.1 and loading time, but it would be nice if it had performance advantage over 3.4.1.
Quick question:
Does it take up texture memory when it loads all the shaders? I noticed that some texture-heavy moments in games have bad time in 4.1.1 over 3.4.1 in performance mode.
Some feedback:
• Regarding user experience, colors settings in theme section feels overwhelming, like there are too many options.
• Changing size of the UI by Ctrl+ScrollWheel makes everything blurry, maybe transition between background and text should be half-pixel?

• Regarding text editor, using Shift+Arrow key works nice at selecting text, but Shift+Mouse drag does not, it would be a nice addition.

Last edit: 3 years 4 months ago by Fu-Bama.
The topic has been locked.
- crosire
-
Topic Author
- Offline
Less More
- Posts: 4030
3 years 4 months ago - 3 years 4 months ago #67 by crosire
There is no garbage collection though: Once an effect is activated all resources will stay in memory even after deactivating it again. This is so that there is no hitch the next time the effect is toggled on, because all resources are already there. To fully unload all effects and textures again click the "Reload" button.
2) The default font is optimized for a single size. Scaling it up or down will make it look bad. You'll have to use a custom font to keep things better looking when scaling the UI. Also the font renderer in ImGui is rather simple, so some blurring is to be expected. There is a branch which uses FreeType for font rasterization, but I don't see an advantage in increasing complexity and adding another dependency for this special case, when the default renderer works fine most of the time.
3) Done: github.com/crosire/reshade/commit/1ab974...aa568f39c25a21d12667
Replied by crosire on topic 4.1.1
Some issues spotted:It loads all shaders, but only compiles the active ones to bytecode. It also only allocates and loads textures for those effects that are active (you can verify that on the Statistics page).
• It seems that version 4 loads all shaders despite performance mode (according to splash-screen at the beginning in DXGI x64)
• I don't know if above is the reason, but performance in 4.1.1 is slightly worse than 3.4.1
There is no garbage collection though: Once an effect is activated all resources will stay in memory even after deactivating it again. This is so that there is no hitch the next time the effect is toggled on, because all resources are already there. To fully unload all effects and textures again click the "Reload" button.
Some feedback:1) That's why the "Custom Simple" style exists.
• Regarding user experience, colors settings in theme section feels overwhelming, like there are too many options.
• Changing size of the UI by Ctrl+ScrollWheel makes everything blurry, maybe transition between background and text should be half-pixel?
• Regarding text editor, using Shift+Arrow key works nice at selecting text, but Shift+Mouse drag does not, it would be a nice addition.
2) The default font is optimized for a single size. Scaling it up or down will make it look bad. You'll have to use a custom font to keep things better looking when scaling the UI. Also the font renderer in ImGui is rather simple, so some blurring is to be expected. There is a branch which uses FreeType for font rasterization, but I don't see an advantage in increasing complexity and adding another dependency for this special case, when the default renderer works fine most of the time.
3) Done: github.com/crosire/reshade/commit/1ab974...aa568f39c25a21d12667
Last edit: 3 years 4 months ago by crosire.
The following user(s) said Thank You: Fu-Bama
The topic has been locked.
- brussell
-
- Offline
Less More
- Posts: 328
3 years 4 months ago #68 by brussell
Replied by brussell on topic 4.1.1
Another two issues:
-the GUI always switches to the last tab (About, DX9, DX11) after reloading. This should rather be the Home tab.
-the scrollbar in the Log tab doesn't work as expected when the log gets a specific size. See my post: reshade.me/forum/troubleshooting/5090-scrollbar-issue
-the GUI always switches to the last tab (About, DX9, DX11) after reloading. This should rather be the Home tab.
-the scrollbar in the Log tab doesn't work as expected when the log gets a specific size. See my post: reshade.me/forum/troubleshooting/5090-scrollbar-issue
The topic has been locked.
- crosire
-
Topic Author
- Offline
Less More
- Posts: 4030
3 years 4 months ago - 3 years 4 months ago #69 by crosire
Replied by crosire on topic 4.1.1
• In Blender 2.79 typing anything in ReShade UI gives double input, like 'error' results in 'eerrrroorr'Fixed: github.com/crosire/reshade/commit/e67f16...2907576f66483695a476
-the GUI always switches to the last tab (About, DX9, DX11) after reloading. This should rather be the Home tab.This is already fixed in 4.1.1.
Last edit: 3 years 4 months ago by crosire.
The following user(s) said Thank You: brussell
The topic has been locked.
- Fu-Bama
-
- Offline
3 years 4 months ago - 3 years 4 months ago #70 by Fu-Bama
Replied by Fu-Bama on topic 4.1.1
Some bug:
When text editor is opened and you switch to performance mode, name of the currently opened shader changes to some other one (experienced in OpenGL).
Recreate bug:
• Open shader X.fx text editor
• Switch to performance mode
• Label in text editor tab changes to Y.fx
When text editor is opened and you switch to performance mode, name of the currently opened shader changes to some other one (experienced in OpenGL).
Recreate bug:
• Open shader X.fx text editor
• Switch to performance mode
• Label in text editor tab changes to Y.fx
Last edit: 3 years 4 months ago by Fu-Bama.
The topic has been locked.
- crosire
-
Topic Author
- Offline
Less More
- Posts: 4030
3 years 4 months ago #71 by crosire
Replied by crosire on topic 4.1.1
When text editor is opened and you switch to performance mode, name of the currently opened shader changes to some other one (experienced in OpenGL).Can't reproduce that. The editor always deselects any shader and shows an empty window after reloading (e.g. by switching performance mode). This is because the effect IDs change after reloading so it is not safe to reference the text of an old one.
The topic has been locked.
- Fu-Bama
-
- Offline
3 years 4 months ago #72 by Fu-Bama
Replied by Fu-Bama on topic 4.1.1
Ok, that was minor thing.
But found another. When you right click on color value to change from RGB to HSV in DirectX9 it shows floating "Reset to default value" button. In UI color settings it works as expected.
But found another. When you right click on color value to change from RGB to HSV in DirectX9 it shows floating "Reset to default value" button. In UI color settings it works as expected.
The topic has been locked.
- crosire
-
Topic Author
- Offline
Less More
- Posts: 4030
3 years 4 months ago - 3 years 4 months ago #73 by crosire
Other option would be to allow that context menu, but that would remove the reset to default value option for color values.
Replied by crosire on topic 4.1.1
But found another. When you right click on color value to change from RGB to HSV in DirectX9 it shows floating "Reset to default value" button. In UI color settings it works as expected.This is explicitly disabled to keep the context menu consistent across all values. See github.com/crosire/reshade/blob/e2ee01fa...source/gui.cpp#L1813 > ImGuiColorEditFlags_NoOptions
Other option would be to allow that context menu, but that would remove the reset to default value option for color values.
Last edit: 3 years 4 months ago by crosire.
The topic has been locked.
- Fu-Bama
-
- Offline
- crosire
-
Topic Author
- Offline
Less More
- Posts: 4030
3 years 4 months ago #75 by crosire
Replied by crosire on topic 4.1.1
It's not duplicated. The button above resets everything in that effect. The context menu only the specific value. ReShade never shows the RGB/HSV context menu on color values (only on a different UI page, namely the settings, which have no connection to effect values).
The topic has been locked.
- Fu-Bama
-
- Offline
- hYpercrites
-
- Offline
Less More
- Posts: 1