3.1

OtisInf wrote: @thalixte: weird! I load your save file, but everything keeps on working here... No matter what angle I take, or where I move the player ... I also downgraded every gfx setting to 'low' as you suggested that the # of vertices dropped below a given threshold so I thought perhaps it's the gfx settings I have (everything maxed) but... nope 1920x1200... works like a charm. Will try other resolutions now but I don't know what triggers it on your part...

(edit) windowed mode, 1440x900 or so, no problem either... very odd. ..

Will now install the photomode mod to see if I can reproduce it without gerhalt's ass in the way

(edit) I remembered I could just use Ansel and I can't reproduce it with that either. Flying around, like you in your video, same spot, using displaydepth, not a problem at all, right depth buffer is chosen every time, looking at a clear sky, all OK... really weird.

ID3D11DepthStencilView* depth_counter_tracker::get_best_depth_stencil(std::unordered_map<ID3D11DepthStencilView*, depthstencil_size> const& depthstencils, UINT width, UINT height)
{
	depthstencil_counter_info best_info = { 0 };
	ID3D11DepthStencilView *best_match = nullptr;
	float aspect_ratio = ((float)width) / ((float)height);

	for (auto it : _counters_per_used_depthstencil)
	{
		const auto depthstencil = it.first;
		auto &depthstencil_info = it.second;
		
		if (depthstencil_info.drawcall_count == 0)
		{
			continue;
		}
		auto sizeinfo = get_depth_stencil_size(depthstencils, depthstencil);
		bool size_mismatch = false; 
		
		LOG(INFO) << "Returning sizeinfo.width " << sizeinfo.width;
		LOG(INFO) << "Returning sizeinfo.height " << sizeinfo.height;
		
		// if the size of the depth stencil has the size of the window, we'll look at its counters. If it doesn't we'll try some heuristics, like
		// aspect ratio equivalence or whether the height is 1 off, which is sometimes the case in some games. 
               // ****** slight modification: check if sizeinfo.width and sizeinfo.height are returned ******
		if (sizeinfo.width > 0 && sizeinfo.height > 0)
		{
			if (sizeinfo.width != width)
			{
				size_mismatch = true;
			}
			if (sizeinfo.height != height)
			{
				// check if height is uneven, some games round depthsize height to an even number.
				if (sizeinfo.height != (height - 1) && sizeinfo.height != (height + 1))
				{
					// not a matching height
					size_mismatch = true;
				}
			}
			if (size_mismatch)
			{
				// check aspect ratio. 
				float stencilaspectratio = ((float)sizeinfo.width) / ((float)sizeinfo.height);
				if (fabs(stencilaspectratio - aspect_ratio) > 0.1f)
				{
					// still no match, not a good fit
					continue;
				}
			}
			
			if (depthstencil_info.drawcall_count >= best_info.drawcall_count)
			{
				best_match = depthstencil;
				best_info = depthstencil_info;
				LOG(INFO) << "Match found !!!";
			}
		}
	}
	return best_match;
}

2018-01-02T21:31:40:401 [03832] | INFO  | Redirecting 'IDXGISwapChain::SetFullscreenState(00000001A92EE7D0, FALSE, 0000000000000000)' ...
2018-01-02T21:31:40:559 [03832] | INFO  | Returning sizeinfo.width 0
2018-01-02T21:31:40:559 [03832] | INFO  | Returning sizeinfo.height 0
2018-01-02T21:31:40:559 [03832] | INFO  | Returning sizeinfo.width 0
2018-01-02T21:31:40:559 [03832] | INFO  | Returning sizeinfo.height 0
2018-01-02T21:31:40:559 [03832] | INFO  | Returning sizeinfo.width 0
2018-01-02T21:31:40:559 [03832] | INFO  | Returning sizeinfo.height 0
2018-01-02T21:31:40:559 [03832] | INFO  | Returning sizeinfo.width 0
2018-01-02T21:31:40:559 [03832] | INFO  | Returning sizeinfo.height 0
2018-01-02T21:31:40:559 [03832] | INFO  | Returning sizeinfo.width 0
2018-01-02T21:31:40:559 [03832] | INFO  | Returning sizeinfo.height 0
2018-01-02T21:31:40:559 [03832] | INFO  | Returning sizeinfo.width 0
2018-01-02T21:31:40:559 [03832] | INFO  | Returning sizeinfo.height 0
2018-01-02T21:31:40:858 [03832] | INFO  | Returning sizeinfo.width 0
2018-01-02T21:31:40:858 [03832] | INFO  | Returning sizeinfo.height 0
2018-01-02T21:31:40:858 [03832] | INFO  | Returning sizeinfo.width 0
2018-01-02T21:31:40:858 [03832] | INFO  | Returning sizeinfo.height 0
2018-01-02T21:31:40:858 [03832] | INFO  | Returning sizeinfo.width 0
2018-01-02T21:31:40:858 [03832] | INFO  | Returning sizeinfo.height 0
2018-01-02T21:31:40:858 [03832] | INFO  | Returning sizeinfo.width 0
2018-01-02T21:31:40:858 [03832] | INFO  | Returning sizeinfo.height 0
2018-01-02T21:31:40:858 [03832] | INFO  | Returning sizeinfo.width 0
2018-01-02T21:31:40:858 [03832] | INFO  | Returning sizeinfo.height 0
2018-01-02T21:31:40:858 [03832] | INFO  | Returning sizeinfo.width 0
2018-01-02T21:31:40:858 [03832] | INFO  | Returning sizeinfo.height 0
2018-01-02T21:31:41:164 [03832] | INFO  | Returning sizeinfo.width 0
2018-01-02T21:31:41:164 [03832] | INFO  | Returning sizeinfo.height 0
2018-01-02T21:31:41:164 [03832] | INFO  | Returning sizeinfo.width 0
2018-01-02T21:31:41:164 [03832] | INFO  | Returning sizeinfo.height 0
2018-01-02T21:31:41:164 [03832] | INFO  | Returning sizeinfo.width 0
2018-01-02T21:31:41:164 [03832] | INFO  | Returning sizeinfo.height 0
2018-01-02T21:31:41:164 [03832] | INFO  | Returning sizeinfo.width 0
2018-01-02T21:31:41:164 [03832] | INFO  | Returning sizeinfo.height 0
2018-01-02T21:31:41:164 [03832] | INFO  | Returning sizeinfo.width 0
2018-01-02T21:31:41:164 [03832] | INFO  | Returning sizeinfo.height 0
2018-01-02T21:31:41:164 [03832] | INFO  | Returning sizeinfo.width 0
2018-01-02T21:31:41:164 [03832] | INFO  | Returning sizeinfo.height 0
2018-01-02T21:31:41:447 [03832] | INFO  | Returning sizeinfo.width 0

2018-01-02T21:30:41:724 [03832] | INFO  | Redirecting 'IDXGISwapChain::SetFullscreenState(00000001A92EE7D0, FALSE, 0000000000000000)' ...
2018-01-02T21:30:41:973 [03832] | INFO  | Returning sizeinfo.width 512
2018-01-02T21:30:41:973 [03832] | INFO  | Returning sizeinfo.height 512
2018-01-02T21:30:41:973 [03832] | INFO  | Returning sizeinfo.width 1024
2018-01-02T21:30:41:973 [03832] | INFO  | Returning sizeinfo.height 1024
2018-01-02T21:30:41:973 [03832] | INFO  | Returning sizeinfo.width 64
2018-01-02T21:30:41:973 [03832] | INFO  | Returning sizeinfo.height 64
2018-01-02T21:30:41:973 [03832] | INFO  | Returning sizeinfo.width 2048
2018-01-02T21:30:41:973 [03832] | INFO  | Returning sizeinfo.height 2048
2018-01-02T21:30:41:973 [03832] | INFO  | Returning sizeinfo.width 0
2018-01-02T21:30:41:973 [03832] | INFO  | Returning sizeinfo.height 0
2018-01-02T21:30:41:973 [03832] | INFO  | Returning sizeinfo.width 2144
2018-01-02T21:30:41:973 [03832] | INFO  | Returning sizeinfo.height 1208
2018-01-02T21:30:41:973 [03832] | INFO  | Match found !!!
2018-01-02T21:30:41:973 [03832] | INFO  | Returning sizeinfo.width 64
2018-01-02T21:30:41:973 [03832] | INFO  | Returning sizeinfo.height 64
2018-01-02T21:30:41:973 [03832] | INFO  | Returning sizeinfo.width 1280
2018-01-02T21:30:41:973 [03832] | INFO  | Returning sizeinfo.height 720
2018-01-02T21:30:41:973 [03832] | INFO  | Returning sizeinfo.width 64
2018-01-02T21:30:41:973 [03832] | INFO  | Returning sizeinfo.height 64
2018-01-02T21:30:41:973 [03832] | INFO  | Returning sizeinfo.width 1072
2018-01-02T21:30:41:973 [03832] | INFO  | Returning sizeinfo.height 604
2018-01-02T21:30:41:973 [03832] | INFO  | Returning sizeinfo.width 2560
2018-01-02T21:30:41:973 [03832] | INFO  | Returning sizeinfo.height 1440
2018-01-02T21:30:42:327 [03832] | INFO  | Returning sizeinfo.width 2048
2018-01-02T21:30:42:327 [03832] | INFO  | Returning sizeinfo.height 2048
2018-01-02T21:30:42:327 [03832] | INFO  | Returning sizeinfo.width 2144
2018-01-02T21:30:42:327 [03832] | INFO  | Returning sizeinfo.height 1208
2018-01-02T21:30:42:327 [03832] | INFO  | Match found !!!

thalixte wrote:

OtisInf wrote: @thalixte: weird! I load your save file, but everything keeps on working here... No matter what angle I take, or where I move the player ... I also downgraded every gfx setting to 'low' as you suggested that the # of vertices dropped below a given threshold so I thought perhaps it's the gfx settings I have (everything maxed) but... nope 1920x1200... works like a charm. Will try other resolutions now but I don't know what triggers it on your part...

(edit) windowed mode, 1440x900 or so, no problem either... very odd. ..

Will now install the photomode mod to see if I can reproduce it without gerhalt's ass in the way

(edit) I remembered I could just use Ansel and I can't reproduce it with that either. Flying around, like you in your video, same spot, using displaydepth, not a problem at all, right depth buffer is chosen every time, looking at a clear sky, all OK... really weird.

Ansel simply disables reshade effects. I use a TW3 mod ( PhotoMode 2inOne for Debug Console Enabler ) to enable the flight mode (with "F1" key).

Really strange, indeed... I play both TW3 and ACO in 1440p...
It seems that the buffer detection fails when sizeinfo.width and sizeinfo.height return 0. It might be related to the depthstencil_size depth_counter_tracker::get_depth_stencil_size method, not returning the right value.

However, i found a workaround to the pb on my config. I made a slight change in the depth_counter_tracker.cpp method named ID3D11DepthStencilView* depth_counter_tracker::get_best_depth_stencil, like this:

(snip)

With this, no more buffer detection fails, except in one case: in ACO, if i return to desktop, then i revert back to the game. For a reason i ignore, the sizeinfo retrieval fails. It does not happen with TW3.

OtisInf wrote: As in: it then never recovers? Or after 30 frames? (as there's a delay). Checking for 0 could be a valuable workaround, however adding code for something that has its cause elsewhere is never a good idea. that said, I'll see if I can find evidence on my system if width/height are 0 as well in some cases...

depthstencil->GetResource(&resource);
if (!FAILED(resource->QueryInterface(&texture)))
{
	texture->GetDesc(&texture_desc);
}
else continue;

OtisInf wrote: Ah you weren't using the latest build! I already wondered wtf was wrong haha Ok, that's a relief, glad it's not something with the code

Your change proposal is a good catch! it's indeed a dumb mistake I made. I'll make the necessary changes and push to the PR so it gets merged too Thanks for testing and feedback!

Marty McFly wrote: Quick question, is it possible to replace the depth buffer with a reserved value like -1 or whatever outside [0,1] range to allow for checking in shader if buffer is invalid? Or for example, add a warning ingame that the correct depth buffer hasn't been found? I get quite a lot of messages about DoF not working, MXAO not working, blaming the shader all the time.

Marty McFly wrote: Quick question, is it possible to replace the depth buffer with a reserved value like -1 or whatever outside [0,1] range to allow for checking in shader if buffer is invalid? Or for example, add a warning ingame that the correct depth buffer hasn't been found? I get quite a lot of messages about DoF not working, MXAO not working, blaming the shader all the time.

OtisInf wrote: tho I doubt that will solve all problems regarding users who blame the wrong thing: e.g. in a game like TombRaider (2013), the game clears the depth buffer before Present, so there's no info in the buffers (there are 2, both are empty), nothing can preserve that. Telling them 'the depth buffer is empty' will mean as much to them as "ahy45r022hgfh shfd!", i.e.: nothing, as a lot of them don't know what a depth buffer is, nor that it's essential for some shaders.

thalixte wrote:

OtisInf wrote: tho I doubt that will solve all problems regarding users who blame the wrong thing: e.g. in a game like TombRaider (2013), the game clears the depth buffer before Present, so there's no info in the buffers (there are 2, both are empty), nothing can preserve that. Telling them 'the depth buffer is empty' will mean as much to them as "ahy45r022hgfh shfd!", i.e.: nothing, as a lot of them don't know what a depth buffer is, nor that it's essential for some shaders.

So, the buffer detection you implemented will not work for every game, what a pity ! But it will for the majority i guess. I don't think there are a big number of games that clear the depthbuffer before the end of the frame rendering.

So, maybe i will tell something really stupid, but i remember that dxd9 GeDoSaTo injector had the ability to inject its own shaders, not only at the end of frame rendering, but also during the frame rendering, as it is explained here ( PC Gamer Durante's article on geDoSaTo ). So, in this case, it would be possible to retrieve depth buffer data before they are removed by the game engine...

OtisInf wrote: there might be a radical different way tho: move everything to the GPU: reshade first runs shader which renders to its output the depth info from the texture that contains data, it renders to the depth buffer texture used by all other shaders (so basically copying it). This is also slower than what we have today btw but could mean an alternative.

crosire wrote: Because it's a false positive. AntiVirus software is not perfect, they make mistakes. For some reason the signature of the setup tool has similarities to an existing malware application, which is why some raise the alarm. A few of the big ones initially complained too, but were since notified, so that their labs checked ReShade, deemed it safe and therefore the detection was fixed so they don't find malware anymore (since there is none).

• Do you plan to change the release version of reshade after your last commits to the master branch on github, that included the lastest updates from OtisInf, and to make it available on the reshade site (or, maybe it is already the case) ?
• Are you working with nvidia folks to provide freestyle, or is it an nvidia exclusive implementation ?

Martigen wrote: Some of these look like they're Reshade shaders (Clarity, HDR toning...)

thalixte wrote: First of all, thk U for this fantastic tool ! I have just two little questions

crosire wrote: 2) I am involved with NVIDIA, yes.

Marty McFly wrote: As far as I know, this is what ENBSeries does. I read multiple times on enbdev that Boris creates his own buffer so I assume he assembles his own one from various accessible as Skyrim has a shitload of different ones.

Also, about HUD masking, are there any identifiers like switch to orthogonal viewport or similar that are always true for when HUD is drawn (but for other occurences as well)? If so, maybe add a switch that cycles through all of them until the right one is found. Current ini layout would allow for such a game specific value. I know you're looking for a way that works on all games automatically but even the depth linearizing requires user interaction.