4.0
- DeMondo
- OtisInf
That will indeed be the case: it will again behave like before and click-to-input is then also working as that's a feature of the drag control. The slider doesn't have that.amoebae wrote:
OtisInf wrote: Would require the old shader code, or manually change 'slider' into 'drag' at the top of the file in a text editor. Use the link I gave above to browse to the old shader version which has 'drag' instead of 'slider' in the variable /control definitions at the top of the file.
so either copy/paste this: raw.githubusercontent.com/crosire/reshad...aders/LumaSharpen.fx
or change 'slider' into 'drag' here: github.com/crosire/reshade-shaders/blob/...s/LumaSharpen.fx#L14 in the file you have on disk (and the other slider definitions of course)
Thanks for the info. So just changing slider to drag for every ui element will make it look and act like it used to? Will the click-to-input function still be there, or was that controlled by something else?
Github is a system where you can store sets of files and each change on each file is logged and you can go back to any previous version of any file. So if you go to the 'commit' page:Also, as someone who isn't familiar at all with github, I find navigating it an almost entirely opaque process. Is there a way for someone (a group effort, perhaps) to make it easy to access old versions of shaders all grouped together as they would be if downloading the current versions? Similar to how we have the repository for old binaries?
github.com/crosire/reshade-shaders/commits/master
You see each set of changes to the files, creating a new version of the set of files (the 'repository'). Now, do you see the buttons on the right with the <> characters? If you click on them, you get the repository at that moment, so all changes made to it after that aren't there. So if you want to go back to the repository state before the change from slider to drag, you have to click to the button on the commit right before it. Which is this one:
github.com/crosire/reshade-shaders/tree/...340a66495ac1ac059c85
If you then click the 'clone or download' button on the right (the green one), you get all shaders with the state of that moment in time.
This could be made easier of course, hence I asked above that there could be added a 'branch' for v3 shaders so you could always go to the state of the v3 shaders without digging through commits.
It indeed leaves a lot to be desired. I added the shaders I made/worked on to a separate repository which are compatible with 3.4.1 and v4: github.com/FransBouma/OtisFX but it's not ideal. Fragmentation isn't great, everything should be in one place.As users and preset authors, there are a ton of presets out there that were made with specific versions of ReShade, and that are tied to the shaders that were released at that time. It's easy to download the relevant binary, but near impossible to get hold of the relevant shaders. As it stands, it's not a particularly user-friendly process.
But alas, this all requires work, from the installer to the repository to add branches/tags so the installer can pull the right shaders, and thus time, which is always a scarce resource. I don't mind helping out, but the whole process of what's planned and what to do best is totally opaque so I don't want to waste time on things that aren't wanted/needed.
- dorez`
I can’t configure it at all and the most important thing I can’t return is version 4.01 with which it worked perfectly. When installing version 4.01, after launching the game, the settings of the new version are released ??? Please help
- CHOPPER
Martigen wrote:
Both of these are working for me with 4.02.CHOPPER wrote: Great update, on the old version, so many of the shaders were broken on Sven Coop now all of them works great!
But the "FXAA" doesn't work anymore, also "PerfectPerspective".
What errors are you getting?
How can I copy the errors? I can't copy with CTRL+C & CTRL+V
- CHOPPER
lowenz wrote:
Did you update the shader package?CHOPPER wrote: Great update, on the old version, so many of the shaders were broken on Sven Coop now all of them works great!
But the "FXAA" doesn't work anymore, also "PerfectPerspective".
Yes
- Marty McFly
- CHOPPER
Martigen wrote:
Both of these are working for me with 4.02.CHOPPER wrote: Great update, on the old version, so many of the shaders were broken on Sven Coop now all of them works great!
But the "FXAA" doesn't work anymore, also "PerfectPerspective".
What errors are you getting?
19:45:56:380 [12280] | ERROR | Failed to compile "
\\SteamLibrary\\steamapps\\common\\Sven Co-op\\reshade-shaders\\Shaders\\FXAA.fx":Vertex shader failed to compile with the following errors:
ERROR: 1:74: error(#132) Syntax error: "noperspective" parse error
ERROR: error(#273) 1 compilation errors. No code generated
19:51:14:990 [12280] | ERROR | Failed to compile "
\\SteamLibrary\\steamapps\\common\\Sven Co-op\\reshade-shaders\\Shaders\\PerfectPerspective.fx":Vertex shader failed to compile with the following errors:
ERROR: 1:142: error(#202) No matching overloaded function found: fwidth
ERROR: 1:142: error(#160) Cannot convert from: "const float" to: "highp 2-component vector of vec2"
ERROR: 1:178: error(#202) No matching overloaded function found: fwidth
ERROR: 1:180: error(#202) No matching overloaded function found: fwidth
ERROR: error(#273) 4 compilation errors. No code generated
- ScorpionBSG
drive.google.com/file/d/1qdbShLP3WQbq87p...msK/view?usp=sharing
- ScorpionBSG
- ScorpionBSG
OtisInf wrote: Github is a system where you can store sets of files and each change on each file is logged and you can go back to any previous version of any file. So if you go to the 'commit' page:
github.com/crosire/reshade-shaders/commits/master
You see each set of changes to the files, creating a new version of the set of files (the 'repository'). Now, do you see the buttons on the right with the <> characters? If you click on them, you get the repository at that moment, so all changes made to it after that aren't there. So if you want to go back to the repository state before the change from slider to drag, you have to click to the button on the commit right before it. Which is this one:
github.com/crosire/reshade-shaders/tree/...340a66495ac1ac059c85
If you then click the 'clone or download' button on the right (the green one), you get all shaders with the state of that moment in time.
This could be made easier of course, hence I asked above that there could be added a 'branch' for v3 shaders so you could always go to the state of the v3 shaders without digging through commits.
...
I added the shaders I made/worked on to a separate repository which are compatible with 3.4.1 and v4: github.com/FransBouma/OtisFX but it's not ideal. Fragmentation isn't great, everything should be in one place.
Otis, this is really useful information, thank you so much. I never would have been able to work out how to access the full shader repo from a specific date without this, thank you. I know a lot of people who will be grateful for it.
I hope there's an easier way in the future, but for now at least I know it can be done with a little bit of digging.
syphlor wrote: Your log looks a little different from mine, mine says the runtime was destroyed and then exiting randomly. Anyone know a fix for this?
This seems similar to what happened to me in No Man's Sky a long time ago (so not with 4.x). It loaded fine and I was using it with no problem, then I got a crash one day and ever since the game will not load with ReShade installed (any version). I never got to the bottom of it.
- OtisInf
- dorez`
- JBeckman
dorez` wrote: And yet someone can tell how to return version 4.01 what and where you need to remove ???
Just download it.
If 4.0.2 is - reshade.me/downloads/ReShade_Setup_4.0.2.exe
Then 4.0.1 would be reshade.me/downloads/ReShade_Setup_4.0.1.exe
And then just overwrite the .dll from 4.0.2 with 4.0.1 if you want to go back to that.
- OtisInf
return = float4(1, 0, 0, 0);
which is obviously wrong, in a pixelshader at the end, you get the message that the shader failed to compile, but the statistics tab shows no line number nor an error of any kind. Opening the editor also doesn't show any error at that spot.
- dorez`
To re-write .dll from 4.0.2 with 4.0.1 how to do it and which DLL ???
- v00d00m4n
CROSIRE, i really appreciate your efforts, but can you please stop this "Microsofting" aka REWRITING WHAT WAS WORKING FINE FROM SCRATCH AND BREAKING WHAT WAS NOT BROKEN, LIKE COMPATIBILITY WITH OLDER SHADERS?
This is getting really annoying!
I was one the very 1st testers of eFX, then you broke it and release eFX rewritten from scratch that lacked many features of initial version
Then you broke eFX and rewrote it from Scratch as Reshade, we all had do rewrite shaders because everything was broken.
Then you broken Reshade 1 with Reshade 2, all comfortable stucture of SweetFX was ruined, folders with authors names and disjoined shaders, also an new non human friendly syntax for disfunctional and clunky mediator came in, and everyone had to do everything from scratch again and old goo fx suits has gone...
Then you broke everything again with Reshade 3, left us with limited settings because you did not came up with simple idea to use preprocessor in same settings just with "Reload shader" button next to it to apply it, and many shaders became really crippled by that. But you returned UI that you actually had back in every 1st reshade iteration eFX... before you broke it! And we all had to rewrite shades and a lot of pioneers of community just rage quit it or lost interest because what they worked on for a whole year or two was single handenly broken bu unnecessary and nigligent changes.
Then with every update you kinda broke something here and and there some useful features like precise sliders and their steps and other minor things that was working fine and wasnt broken and did not require fixing... also in general Reshade 3 was less compatible with many games than 2.
And here comes Reshade 4 and guess what? It was rewritten from scratch and broke a lot of things that was not broken before.
There is a basic rule in IT industry that everyone should follow - if aint broken - dont fix it! Why do you always had to rewrite everything from scratch and fix what was not broken? Cant you just keep updating what you already have incrementaly? Or at least if you rewriting, can you mimic everything that was present before and dont forget to bring everything back for 100% compatibility? Or at least make some automation tool that can update old shaders into new format and fix code syntax patterns that was changed between versions, and even integrate it into reshade itself and on first launch scan shaders for compatibility changes and backup old shaders in separate folder and autoupdate them with new syntax!
Also, why in a word you use same repo for reshade 2 and 3 and now 4? We got this problem with 2 with you replaced human friendly shaders with mediator friendly, than we had same issue with 3 when you just replace old 2 shaders with 3, now you did it again with 4... and like all the previous times you just broke old reshade because due of changes in code whenever people will install reshade 3 they will get repo with reshade 4 updated code and some failur may happen! You did not learn from mistae you did many times before.
Every time you do a major changes that breaks some code - start new repository or branch of repo for new version, to keep branches separate and compatible with correspoding version. Also whole practics of removing download links for old reshades that are stable and has compatible shaders is bad, and you keep doing it instead of just adding new version to a list with all the previous releases!
You a great programmer and did a great tool, but when it comes to care for users and shader developers comfortability you dont think one step ahead and keep doing things that gets people expirience with new versions worse and gets people frustrated, this is not how it should be done! People still a little angry at you at how you broke fundamental things with 3 and never fixed most of them... And the most major overhaul of 3 flaws happened after my previous angry rant about things you did wrong, before it you did not even realise obvious flaws of 3, but then again back than even problem with lack of relative default pathes was not fixed, and preprocessor suggestion was not taken into account... glaldy we now return to relative pathes in 4, some ui changes was for good, but rewriting was no really nessary and some fundamental flaws like lack of per shader preprocessor settings with recompile shader next to it, was not fixed, like bunch of other problems... and now we have even more problems and again need to update shaders because you removed some usefull syntax support instead of keeping or wrapping it to a new syntax for sake of compatibility... this is why you see my angry rant again.
How about next time, before you decide to rewrite everything from sratch, you will write an annoucment of you plans, explain why you think its good idea and how you gonna do it, listen to what people said, or even better - before fixing what was not broken - start a thread of suggestions of what people want to see, what they like what they dont like, and prioritize next updates and overhauls based on most common needs and suggestion of people, instead of decising it for yourself?
While you creator of Reshade, its only a half of what makes its great - the other part is pack of shaders made by community, so Reshade is not completely yours anymore, its a symbiosis of yours and ours, and you cant just decide for all of us "im going to change syntax and break all of your shaders you spent years on!", you have to ask us, and 100% compatibility should be you number priority no matter what you do, and you have care for users and shader creators and consult with us before making any radical changes.
While i apreciate reasoning behind your urge to rewrite everything to make something better, you always keep forgeting about some important stuff and keep making something worse in process which is hard to apreciate...
- OtisInf
That said, please consider this is an OSS effort and your long rant basically tells the OSS maintainer to go fuck themselves. It's not easy to migrate to new versions and avoid frustration, but that's life. I don't like v4's UI as well, but that doesn't mean I think a rant like yours is justified. Maintaining an OSS project is tough, you invest a lot of free time in stuff that will always generate new bug reports, feature requests, 'how-do-I' requests from users and rants from people who would have liked it moved in a different direction.
Rants like the one you posted definitely don't help. Please consider the project is maintained by a person doing that in his free time (mostly). Asking someone to spend their free time on something you want isn't fun, it's work, but thing is: you're not their manager and they're not your employee.
Haven't I felt frustration when v4 came out and e.g. 'drag' was now a 'slider'? Sure. But I also know what telling the maintainer 'WTF were you thinking!?' does, as I maintain a lot of OSS myself. I tried to avoid a rant as I know it isn't something you should do, we're talking about free stuff someone made for themselves and shared online and we all can use it for free.
And you're going to rant about how that's suddenly not doing what you want? I don't want to see what you say when you're using commercial software!
OSS has a great feature: you can simply change it and make it do what you want yourself and supply the changes back, if you want to. That's far more productive than ranting. So if you want to have it move to a different direction: step in, write the feature and submit a PR.
But ultimately it's not productive to rant about it. Better to start a thoughtful conversation with suggestions about how it might be made more user and shader-author friendly in the future, and get a discussion going. That's going to better benefit the whole ReShade project in the long run, especially if some kind of regular dialogue and thread for discussions about this can be started.
I definitely see the benefit of having users, shader authors, preset authors, and crosaire all having input. End users have different requirements to shader authors, preset authors generally tend to straddle a murky limbo somewhere between the two, and all will have valuable input to bring in terms of how reshade can be as efficient and user-friendly as possible, from the gui to installation and shader archiving to implementation.