MasterEffect ReBorn official thread

More
5 years 8 months ago - 5 years 8 months ago #261 by SunBroDave
Replied by SunBroDave on topic MasterEffect ReBorn official thread

Ioxa wrote: I took a grayscale of the original image, made it brighter, then blended it into the AO mask. It's six lines of code, if Marty is cool with it I'll post the code and tell you were to paste it.

It still looks weird in some places but it is much less noticeable. And you can raise the AO power and it still won't show through the lights, these settings just looked the most subtle to me.

Gotcha so you did do that grayscale thing. I had a similar problem of AO showing through fog when playing Inquisition, and in normal circumstances I actually find Raymarch to be a bit excessive, so this kind of seems like the perfect balance for my tastes. If Marty doesn't mind, I'd love to try it.
Last edit: 5 years 8 months ago by SunBroDave.

Please Log in or Create an account to join the conversation.

More
5 years 8 months ago - 5 years 8 months ago #262 by Marty McFly
Replied by Marty McFly on topic MasterEffect ReBorn official thread
ao = lerp(ao, 1.0,smoothstep(0.3, 0.6, dot(color.xyz,0.333)));

Is a one-liner though. Post what you want, new wip version uses that stuff already :P
What this above does is decreasing AO as soon as the color brightness level reaches 0.3 and linearly lowers the AO intensity until it reaches 0 at color brightness level 0.6. If you want only very bright areas to stay "unambientoccluded", raise both values. Also I don't think "ao" was the variable name I chose in old version and also make sure you put it into the right place.
Last edit: 5 years 8 months ago by Marty McFly.
The following user(s) said Thank You: SunBroDave, jas01

Please Log in or Create an account to join the conversation.

More
5 years 8 months ago #263 by SunBroDave
Replied by SunBroDave on topic MasterEffect ReBorn official thread
Thanks Marty, and can't wait to see what you've been working on for the new version of ME!

Please Log in or Create an account to join the conversation.

More
5 years 8 months ago #264 by Ioxa
Replied by Ioxa on topic MasterEffect ReBorn official thread
Cool, thanks Marty.

So here is the code I used. Scroll down to line 4046 and paste it just above the line that says "return vOutColor;".
float4 res = float4(0.0, 0.0, 0.0, 0.0);
res.xyz = tex2D(SamplerColorLDR, IN.txcoord.xy).xyz;
res = dot(float3(0.21, 0.72, 0.07), res.xyz) + 0.55;
vOutColor = saturate(lerp(vOutColor + 0.5, res, 0.43));
I bumped the RayAO_Power up to 5.5 to strengthen the effect a little.

As for the code Marty posted, I think it can go in the same spot or a little further down at line 4190, it looked the same to me in both places. If you put it at line 4046 it should look like this,
float4 res = float4(0.0, 0.0, 0.0, 0.0);
res.xyz = tex2D(SamplerColorLDR, IN.txcoord.xy).xyz;
vOutColor = lerp(vOutColor, 1.0,smoothstep(0.3, 0.6, dot(res.xyz,0.333)));

If you put it at line 4190, put it above the line that says "res.xyz *= aores;" and below the line that says "#else". And this is the code if you put it there,
aores = lerp(aores, 1.0,smoothstep(0.3, 0.6, dot(res.xyz,0.333)));

I could be wrong on where Marty's code should go but it seemed to work like he said it would, correct me if its wrong though.
And as for my code, it causes a compile warning, because what good would some random guys code be if it didn't cause some sort of error, but it does work.
The following user(s) said Thank You: SunBroDave

Please Log in or Create an account to join the conversation.

More
5 years 8 months ago #265 by Marty McFly
Replied by Marty McFly on topic MasterEffect ReBorn official thread
MasterEffect ReBorn updated to 1.1.111 B) , see first post for abridged changelog. Currently FXAA, Tilt Shift and LeiFX are not available but will be re-added (besides LeiFX).
The following user(s) said Thank You: Wicked Sick, SunBroDave, Alex_outer, padolamap, vfxninjaeditor, Constantine PC, BrandonHortman, jas01, Elimina, TinchO and 2 other people also said thanks.

Please Log in or Create an account to join the conversation.

More
5 years 8 months ago #266 by TinchO
Replied by TinchO on topic MasterEffect ReBorn official thread
Nice Marty, thanks! I'll test it right away

Please Log in or Create an account to join the conversation.

More
5 years 8 months ago - 5 years 8 months ago #267 by Constantine PC
Replied by Constantine PC on topic MasterEffect ReBorn official thread
Nice! I was not expecting this today :)

The Separate Sections for Effects is really nice.
And Hud Masking :woohoo:
Last edit: 5 years 8 months ago by Constantine PC.

Please Log in or Create an account to join the conversation.

More
5 years 8 months ago #268 by Constantine PC
Replied by Constantine PC on topic MasterEffect ReBorn official thread
Hey Marty, I was wondering if you could shed some insight on a question I have. But bare with me, I don't know much about this stuff.

Basically, I want to know if there is a way to hud mask certian effects like DOF or maybe tiltshift(in the future), instead of masking all effects.
The reason I want to know if this is possible or maybe be able to do this is because some games like Arma 3 for instance have transparent Hud elements and if I were to mask those elements it would look very odd because you would just be able to see through to the original game look.

For example:
Warning: Spoiler!


Arma 3 has Hud icons like that. I'm sure some other games do as well.
Any info on how to maybe just mask certian effects or even taking this into consideration for later releases of Master Effect would be really appreciated. Thanks :)

Please Log in or Create an account to join the conversation.

More
5 years 8 months ago #269 by vfxninjaeditor
Replied by vfxninjaeditor on topic MasterEffect ReBorn official thread
Any reason why toggle is tied to the Space key? I kinda use jump for that. :P

Please Log in or Create an account to join the conversation.

More
5 years 8 months ago - 5 years 8 months ago #270 by Wicked Sick
Replied by Wicked Sick on topic MasterEffect ReBorn official thread
@vfxninjaeditor

You can change toggle by opening the ReShade.fx and changing the line 2528. Or run a search for "toggle", then you can set the key you want.


I have a question, is the SMAA working as intended for now? I guess I am not seeing its effect in game.
Last edit: 5 years 8 months ago by Wicked Sick.

Please Log in or Create an account to join the conversation.

More
5 years 8 months ago - 5 years 8 months ago #271 by matsilagi
Replied by matsilagi on topic MasterEffect ReBorn official thread

Wicked Sick wrote: @vfxninjaeditor

You can change toggle by opening the ReShade.fx and changing the line 2528. Or run a search for "toggle", then you can set the key you want.


I have a question, is the SMAA working as intended for now? I guess I am not seeing it's effect in game.


Yeah, its been working since it was first added into one of the betas i tested, and it works.
Last edit: 5 years 8 months ago by matsilagi.

Please Log in or Create an account to join the conversation.

More
5 years 8 months ago - 5 years 8 months ago #272 by Elimina
Replied by Elimina on topic MasterEffect ReBorn official thread
Marty, i love that you released the update unexpectantly, but i cant test it cause im on vacation :( so sad. Cant wait to see the new lensflare blur and masking!!
Last edit: 5 years 8 months ago by Elimina.

Please Log in or Create an account to join the conversation.

More
5 years 8 months ago #273 by Constantine PC
Replied by Constantine PC on topic MasterEffect ReBorn official thread

matsilagi wrote:

Wicked Sick wrote: @vfxninjaeditor

You can change toggle by opening the ReShade.fx and changing the line 2528. Or run a search for "toggle", then you can set the key you want.


I have a question, is the SMAA working as intended for now? I guess I am not seeing it's effect in game.


Yeah, its been working since it was first added into one of the betas i tested, and it works.


It's not working for me either, the Debug does but the actual Anti Aliasing doesn't.

Please Log in or Create an account to join the conversation.

More
5 years 8 months ago #274 by Wicked Sick
Replied by Wicked Sick on topic MasterEffect ReBorn official thread
awwn I am quit unlucky. I was trying to mimic the same settings I used with SFW, but the result wasn't the same. Could you tell me a good settings to resolve this?

i.imgur.com/AFrym9A.png

i.imgur.com/HPo6KbR.png

Please Log in or Create an account to join the conversation.

More
5 years 8 months ago #275 by Constantine PC
Replied by Constantine PC on topic MasterEffect ReBorn official thread

Wicked Sick wrote: awwn I am quit unlucky. I was trying to mimic the same settings I used with SFW, but the result wasn't the same. Could you tell me a good settings to resolve this?

i.imgur.com/AFrym9A.png

i.imgur.com/HPo6KbR.png


I'm pretty sure the SMAA is just straight up not working.
No problem with your settings.

Please Log in or Create an account to join the conversation.

More
5 years 8 months ago - 5 years 8 months ago #276 by Paperboy
Replied by Paperboy on topic MasterEffect ReBorn official thread

Constantine PC wrote: I'm pretty sure the SMAA is just straight up not working.


It hasn't worked so far for me, either.
Last edit: 5 years 8 months ago by Paperboy.

Please Log in or Create an account to join the conversation.

More
5 years 8 months ago - 5 years 8 months ago #277 by Tidias
Replied by Tidias on topic MasterEffect ReBorn official thread
Same for me, SMAA not working.
Last edit: 5 years 8 months ago by Tidias.

Please Log in or Create an account to join the conversation.

More
5 years 8 months ago #278 by jijidasu
Replied by jijidasu on topic MasterEffect ReBorn official thread
Thanks for the new release!

A quick question - would it be too much to ask for more control over the DoF (particularly Petka). I have been using this with FFXIV and find it is the most suitable for a game of this sort wherein the HUD can often be overwhelmed by strong blur. The new release is far more stable and runs great, although I have lost control over things such as being able to manually define focalDepth, focalLength, fStop and so on.

If there is some way to alter these in the new release I'd be grateful for any help with finding where I might configure them.

Please Log in or Create an account to join the conversation.

More
5 years 8 months ago #279 by Tidias
Replied by Tidias on topic MasterEffect ReBorn official thread
Their HUD Masking: Uses a texture mask (mcmask.png) to exclude certain screen areas from effects processing.

Please Log in or Create an account to join the conversation.

More
5 years 8 months ago #280 by jijidasu
Replied by jijidasu on topic MasterEffect ReBorn official thread
Thanks for your reply. Not quite what I had in mind though. I'll stick with the old release for a little while until I can find how to change more settings within DoF.

Please Log in or Create an account to join the conversation.